Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use automaxprocs to automatically set GOMAXPROCS #1360

Closed
jon-rei opened this issue Jul 12, 2023 · 1 comment · Fixed by #1363
Closed

Use automaxprocs to automatically set GOMAXPROCS #1360

jon-rei opened this issue Jul 12, 2023 · 1 comment · Fixed by #1363
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jon-rei
Copy link
Contributor

jon-rei commented Jul 12, 2023

Description

With a large number of CPU threads on nodes, the trivy operator is throttled.
We have implemented a solution with kustomize to add the GOMAXPROCS environment variable with the appropriate CPU limit to avoid throttling. We would like to avoid this workaround and not use kustomize.

Possible solution

Use https://github.com/uber-go/automaxprocs to "Automatically set GOMAXPROCS to match Linux container CPU quota."
@jon-rei jon-rei added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 12, 2023
@chen-keinan
Copy link
Contributor

@jon-rei happy to have this change , feel free to raise a PR

@jon-rei jon-rei mentioned this issue Jul 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add automaxprocs to automatically set GOMAXPROCS
2 participants
@chen-keinan @jon-rei