-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move file patterns to a global level to be able to use it on any analyzer #2539
Merged
knqyf263
merged 12 commits into
aquasecurity:main
from
jerbob92:feature/move-file-patterns-to-global
Sep 1, 2022
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3cde180
Implement global file patterns
jerbob92 1ee85e9
Merge branch 'aquasecurity:main' into feature/move-file-patterns-to-g…
jerbob92 6cfb41f
Remove dead code
jerbob92 e2c443e
Try to fix goimports issue
jerbob92 c8eb742
Fix test
jerbob92 77800f1
Merge main
jerbob92 a6fcb62
Fix file formatting
jerbob92 a448c27
Fix misconf patterns
jerbob92 aadc686
Fix misconf test
jerbob92 2d3a17c
Properly pass file patterns
jerbob92 21a3240
Implement AnalyzerGroup file pattern matching in a separate method
jerbob92 94a8222
Update config file documentation
jerbob92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package all | ||
|
||
import ( | ||
_ "github.com/aquasecurity/trivy/pkg/fanal/analyzer/config/dockerfile" | ||
_ "github.com/aquasecurity/trivy/pkg/fanal/analyzer/config/helm" | ||
_ "github.com/aquasecurity/trivy/pkg/fanal/analyzer/config/json" | ||
_ "github.com/aquasecurity/trivy/pkg/fanal/analyzer/config/terraform" | ||
_ "github.com/aquasecurity/trivy/pkg/fanal/analyzer/config/yaml" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having it in a dedicated method seems better.
func (ag AnalyzerGroup) filePatternMatch(analyzerType Type, filePath string) {
for _, pattern := range ag.filePatterns[analyzerType] {
if pattern.MatchString(cleanPath) {
return true
}
}
return false
}