Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #9

Open
SudoCat opened this issue Apr 28, 2020 · 6 comments
Open

HTTPS support #9

SudoCat opened this issue Apr 28, 2020 · 6 comments

Comments

@SudoCat
Copy link

SudoCat commented Apr 28, 2020

It doesn't seem to be possible to use this proxy with a HTTPS/SSL host - is that correct?

@marconi1992
Copy link
Member

marconi1992 commented Apr 28, 2020

That's correct. We're not supporting hosts with HTTPS/SSL mainly because Nova Proxy was planned to be used as a sidecar proxy, then we can use https in outer layers e.g a load balancer.

@marconi1992
Copy link
Member

good catch! @SudoCat, we'll elaborate more that explanation and update the Readme file accordingly.

@SudoCat
Copy link
Author

SudoCat commented Apr 28, 2020

Thanks for the lightning fast response! I must admit that this sort of thing is far outside my area of expertise, but we're hoping to use the ara framework to help us slowly migrate our front end away from a monolithic java ecommerce platform; I'm worried this limitation might prove to be an impassable blocker for our use case.

Would there be any plans to add SSL support to the proxy layer, or would we need to consider forking/utilising an alternative?

@marconi1992
Copy link
Member

Unfortunately, we don't have plans to add SSL support. We guess decoding the response to parse the HTML, as well as, coding it back could add performance issues. However, as I said it's only I guess. Let's keep open this issue and we'll make a proof of concept to see what we get.

@zeenotheinventor
Copy link

I'm interested in this as well. Would you be okay with me raising a PR to add this functionality?

@marconi1992
Copy link
Member

Sure @zeenotheinventor feel free to do it, I'll really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants