chore: document subgraph schema #583
Conversation
| " Tokens held by the DAO. " | ||
| token: ERC20Contract | ||
|
|
There was a problem hiding this comment.
@Michael-A-Heuer for visibility
this attribute is not accurate any more, but also need some planning
| balances: [TokenBalance!]! @derivedFrom(field: "dao") | ||
|
|
||
| " The permissions given to a DAO to govern its actions (refer to `Objects/Permission` in this documentation site for more information). " |
There was a problem hiding this comment.
only commenting it here
thinks like : (refer to Objects/Permission in this documentation site for more information) does this create an actual link?
There was a problem hiding this comment.
no, it doesn't, I haven't add a proper link as it will feel super odd when seeing the schema (as it would be a relative path from another repo). I can add it though
packages/subgraph/schema.graphql
Outdated
| " The address of the trusted forwarder required for meta transactions, if added while creating the DAO. " | ||
| trustedForwarder: Bytes | ||
|
|
||
| " Deprecated field. " | ||
| signatureValidator: Bytes | ||
|
|
There was a problem hiding this comment.
@Michael-A-Heuer what should we do with trustedForwarder ? is't this also to be deprecated
banasa44
requested review from
heueristik
and removed request for
clauBv23 and
jordaniza
| " Tokens held by the DAO. " | ||
| token: ERC20Contract | ||
|
|
| helpers: [Bytes!]! | ||
|
|
||
| " The array of multi-targeted permission operations to be applied by the `PluginSetupProcessor` to install/uninstall/update the plugin in the DAO. " |
There was a problem hiding this comment.
I don't think you strictly need to apply multi target permissions
There was a problem hiding this comment.
We are inside PluginPreparation entity, which has permissions that will be handled by the psp which only uses applyMultiTargetPermission function
Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com> Co-authored-by: Jordan <45881807+jordaniza@users.noreply.github.com>
banasa44
changed the title
Description
2nd part of the inline comments for subgraph schema. These are meant to be reflected in our auto-generated documentation (subgraph/reference-guide) in our developer-portal.
https://subgraph.satsuma-prod.com/aragon/osx-carles-sepolia/playground
Task ID: OS-1206
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.DEPLOYMENT_CHECKLISTfile in the root folder.UPDATE_CHECKLISTfile in the root folder.