Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-10656 Handling situation when 'results' key is missing in response #52

Conversation

gecbla
Copy link
Contributor

@gecbla gecbla commented May 23, 2023

No description provided.

nemke
nemke previously approved these changes May 24, 2023
Copy link
Contributor

@AnthonyPorthouse AnthonyPorthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have an exception we shouldn't be setting the results key at all. The calling code should handle this by checking for the response status first.

@davorzdralo davorzdralo requested a review from nemke June 7, 2023 06:27
@gecbla
Copy link
Contributor Author

gecbla commented Jun 7, 2023

@AnthonyPorthouse Can I get a ✅ as you were the one requesting changes?

@gecbla gecbla merged commit fd1da0b into master Jun 9, 2023
@gecbla gecbla deleted the bugfix/IT-10656-problem-with-sis-sdk-while-syncing-ernest-bevin-academy-timetable-slots branch June 9, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants