Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenant_route() helper method should accept mixed $parameters #241

Closed
seanmtaylor opened this issue Dec 6, 2019 · 3 comments
Closed

tenant_route() helper method should accept mixed $parameters #241

seanmtaylor opened this issue Dec 6, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@seanmtaylor
Copy link
Contributor

Describe the bug

The tenant_helper() method has a $parameters parameter.

This is currently set to accept an array.

It should be left as mixed to allow for non-arrays to be used, just like the route() helper method.

Steps to reproduce

  1. tenant_route('foo', $bar)

Expected behavior

Using tenant_route('foo', $bar) should work in the same way that route('foo', $bar) would work.

Your setup

  • Laravel version: 6.6.0
  • stancl/tenancy version: 2.2.2
  • Storage driver: Database
@seanmtaylor seanmtaylor added the bug Something isn't working label Dec 6, 2019
@stancl
Copy link
Member

stancl commented Dec 6, 2019

Hi, thanks for reporting. Nice catch.

Can you make a PR that removes the typehint?

@stancl
Copy link
Member

stancl commented Dec 6, 2019

Fixed.

@stancl stancl closed this as completed Dec 6, 2019
@seanmtaylor
Copy link
Contributor Author

That was quick, thanks @stancl 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants