Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration paths #268

Merged
merged 7 commits into from
Feb 16, 2020
Merged

Migration paths #268

merged 7 commits into from
Feb 16, 2020

Conversation

oxidand
Copy link
Contributor

@oxidand oxidand commented Jan 18, 2020

Allow to pass multiple paths to where tenant migrations are stored. This way if the project have many migrations and they are separated into modules we can include them through config, e.g. config(['tenancy.migrations_paths' => ['/path/one', '/path/two']]);

@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #268 into 2.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #268      +/-   ##
============================================
+ Coverage     87.64%   87.69%   +0.04%     
- Complexity      378      380       +2     
============================================
  Files            58       58              
  Lines          1101     1105       +4     
============================================
+ Hits            965      969       +4     
  Misses          136      136              
Impacted Files Coverage Δ Complexity Δ
src/Tenant.php 93.65% <0.00%> (-0.05%) 46.00% <0.00%> (ø%)
src/TenantManager.php 95.62% <0.00%> (+0.03%) 49.00% <0.00%> (ø%) ⬆️
...rc/TenantDatabaseManagers/MySQLDatabaseManager.php 85.71% <0.00%> (+2.38%) 6.00% <0.00%> (+1.00%) ⬇️
...nantDatabaseManagers/PostgreSQLDatabaseManager.php 83.33% <0.00%> (+3.33%) 6.00% <0.00%> (+1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebb68e...11e8a31. Read the comment docs.

tests/CommandsTest.php Outdated Show resolved Hide resolved
curious-jim and others added 2 commits February 9, 2020 17:13
Co-Authored-By: Samuel Štancl <samuel.stancl@gmail.com>
Co-Authored-By: Samuel Štancl <samuel.stancl@gmail.com>
Copy link
Member

@stancl stancl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, final round of changes. Since paths is plural, migration should be singular. Also fixed one bug.

Please click Commit suggestion for each suggestion and I'll merge the PR.

src/Traits/DealsWithMigrations.php Outdated Show resolved Hide resolved
tests/CommandsTest.php Outdated Show resolved Hide resolved
tests/TestCase.php Outdated Show resolved Hide resolved
curious-jim and others added 3 commits February 16, 2020 11:28
Co-Authored-By: Samuel Štancl <samuel.stancl@gmail.com>
Co-Authored-By: Samuel Štancl <samuel.stancl@gmail.com>
Co-Authored-By: Samuel Štancl <samuel.stancl@gmail.com>
@stancl stancl merged commit 06ee1ff into archtechx:2.x Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants