Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seeder params in tenants:seed instead of just the automatic seeder #317

Merged
merged 4 commits into from
Mar 17, 2020

Conversation

stancl
Copy link
Member

@stancl stancl commented Mar 14, 2020

Resolves #307

@stancl stancl added this to the 2.3.0 milestone Mar 14, 2020
@stancl stancl self-assigned this Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #317 into 2.x will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #317      +/-   ##
============================================
- Coverage     87.92%   87.83%   -0.10%     
- Complexity      428      429       +1     
============================================
  Files            61       61              
  Lines          1209     1208       -1     
============================================
- Hits           1063     1061       -2     
- Misses          146      147       +1     
Impacted Files Coverage Δ Complexity Δ
src/Commands/Seed.php 93.33% <100.00%> (+1.02%) 4.00 <0.00> (+1.00)
src/Jobs/QueuedTenantDatabaseSeeder.php 40.00% <100.00%> (-2.86%) 2.00 <1.00> (ø)
src/TenantManager.php 94.32% <100.00%> (-1.45%) 52.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776af46...601baab. Read the comment docs.

@stancl stancl merged commit 526f082 into 2.x Mar 17, 2020
@stancl stancl deleted the use-seeder-params-by-seeder branch March 17, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeder parameters class not use in tenants:seed command
1 participant