Add return value to execute method #333
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #333 +/- ##
============================================
+ Coverage 87.87% 88.78% +0.91%
Complexity 431 431
============================================
Files 61 61
Lines 1212 1213 +1
============================================
+ Hits 1065 1077 +12
+ Misses 147 136 -11
Continue to review full report at Codecov.
|
|
Perfect quality PR, thank you so much! Will tag a release with this and one other bug fix tomorrow. |
| @@ -26,6 +26,8 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $this->laravel->call([$this, 'handle']); | |||
| }); | |||
| } | |||
|
|
|||
| return 1; | |||
There was a problem hiding this comment.
@devonmather Actually, why are we returning 1 here? What's the reason for this and why 1 and not 0?
There was a problem hiding this comment.
The reason is it must return an integer value, I think it's related to the latest symfony component for commands. Upon further reading just now. I misunderstood the error and figured a 0 would be if the command failed. But upon further reading it looks like the default return value is zero. I can created another PR this evening to fix.
There was a problem hiding this comment.
@devonmather Seems like Laravel casts the return value from handle() into an int and returns that. See this: https://github.com/laravel/framework/blob/7.x/src/Illuminate/Console/Command.php#L134
I guess most handle() methods return nothing, so null, which is cast into 0 - as success? And then the handle() method can optionally return for example 1 as a specific exit code? I'll open a PR and ask you for review, if you'd be so kind. I don't have that much experience with commands.
Fixes the following error as demonstrated with test in PR and error below. Occurs after updating to Laravel 7.x and Tenancy 2.3
Let me know if further changes are needed ✌🏻