fix: updating logic for how we deal with infiniteGasMeter (#467)

* handling behavior change in infinitegasmeter.Limit() * reflect no mo
archway-network · Oct 10, 2023 · 39faa9a · 39faa9a
1 parent 12496d3
commit 39faa9a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/x/rewards/keeper/min_cons_fee.go b/x/rewards/keeper/min_cons_fee.go
@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	"github.com/archway-network/archway/pkg"
@@ -17,16 +19,17 @@ func (k Keeper) UpdateMinConsensusFee(ctx sdk.Context, inflationRewards sdk.Coin
 
 	inflationRewardsAmt := sdk.NewDecFromInt(inflationRewards.Amount)
 
-	blockGasLimit := pkg.NewDecFromUint64(ctx.BlockGasMeter().Limit())
-	if blockGasLimit.IsZero() {
+	blockGasLimit := ctx.BlockGasMeter().Limit()
+	if blockGasLimit == math.MaxUint64 { // Because thisss https://github.com/cosmos/cosmos-sdk/pull/9651
 		k.Logger(ctx).Info("Minimum consensus fee update skipped: block gas limit is not set")
 		return
 	}
 
 	txFeeRebateRatio := k.TxFeeRebateRatio(ctx)
 
 	// Calculate
-	feeAmt := calculateMinConsensusFeeAmt(inflationRewardsAmt, blockGasLimit, txFeeRebateRatio)
+	blockGasLimitAsDec := pkg.NewDecFromUint64(blockGasLimit)
+	feeAmt := calculateMinConsensusFeeAmt(inflationRewardsAmt, blockGasLimitAsDec, txFeeRebateRatio)
 	if feeAmt.IsZero() || feeAmt.IsNegative() {
 		k.Logger(ctx).Info("Minimum consensus fee update skipped: calculated amount is zero or bellow zero")
 		return

diff --git a/x/rewards/keeper/tracking.go b/x/rewards/keeper/tracking.go
@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
 
@@ -18,9 +20,14 @@ func (k Keeper) TrackFeeRebatesRewards(ctx sdk.Context, rewards sdk.Coins) {
 
 // TrackInflationRewards creates a new inflation reward record for the current block.
 func (k Keeper) TrackInflationRewards(ctx sdk.Context, rewards sdk.Coin) {
+	blockGasLimit := ctx.BlockGasMeter().Limit()
+	if ctx.BlockGasMeter().Limit() == math.MaxUint64 { // Because thisss https://github.com/cosmos/cosmos-sdk/pull/9651
+		blockGasLimit = 0
+	}
+
 	k.state.BlockRewardsState(ctx).CreateBlockRewards(
 		ctx.BlockHeight(),
 		rewards,
-		ctx.BlockGasMeter().Limit(),
+		blockGasLimit,
 	)
 }