-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dapr secret provider #412
base: main
Are you sure you want to change the base?
feat: add dapr secret provider #412
Conversation
✅ Deploy Preview for arcus-security ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…jnmoreels/arcus.security into feature/dapr-secret-provider
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 20 20
Lines 1065 1065
Branches 82 82
=======================================
Hits 957 957
Misses 79 79
Partials 29 29 ☔ View full report in Codecov by Sentry. |
…jnmoreels/arcus.security into feature/dapr-secret-provider
|
||
# Dapr secret provider | ||
Dapr secret provider brings secrets from the Dapr secret store to your application. Dapr is commonly used in Kubernetes environments where there is usually not the same network capabilities as other application environments. | ||
By using this secret provider, you still benefit from all the Arcus secret store features, while still using Dapr as your external secret source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dapr is not really a secret provider. It has the capabilities to connect to a secret provider and ads a layer of abstraction.
People that are looking for using Dapr will probably understand this, but I'm not sure on how we can improve this text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change it to Dapr secret management brings external secrets to your application.
? As they talk about 'secret management' in their docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the suggestion here, @fgheysels better?
docs/preview/03-Features/secret-store/provider/dapr-secret-store.md
Outdated
Show resolved
Hide resolved
docs/preview/03-Features/secret-store/provider/dapr-secret-store.md
Outdated
Show resolved
Hide resolved
…re.md Co-authored-by: Frederik Gheysels <frederik.gheysels@telenet.be>
…re.md Co-authored-by: Frederik Gheysels <frederik.gheysels@telenet.be>
Add a secret provider that includes the secrets from the Dapr secret store to the Arcus secret store.
Closes #410