always use entire field node as cache key

ardatan · Apr 18, 2023 · 071ac34 · 071ac34
1 parent fb7a24d
commit 071ac34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/batch-delegate/src/getLoader.ts b/packages/batch-delegate/src/getLoader.ts
@@ -81,7 +81,7 @@ export function getLoader<K = any, V = any, C = K>(options: BatchDelegateOptions
 
   let cacheKey = fieldName;
 
-  if (fieldNodes[0]?.selectionSet != null) {
+  if (fieldNodes[0]) {
     const fieldNode = {
       ...fieldNodes[0],
       alias: undefined,

diff --git a/packages/batch-delegate/tests/basic.example.test.ts b/packages/batch-delegate/tests/basic.example.test.ts
@@ -97,7 +97,7 @@ describe('batch delegation within basic stitching example', () => {
     expect(chirps[0].chirpedAtUser.email).not.toBe(null);
   });
 
-  test.only('uses a single call even when delegating the same field multiple times', async () => {
+  test('uses a single call even when delegating the same field multiple times', async () => {
     let numCalls = 0;
 
     const chirpSchema = makeExecutableSchema({