Avoid using globalThis

ardatan · Dec 9, 2021 · 7fa08fc · 7fa08fc
1 parent 595c687
commit 7fa08fc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/.changeset/mighty-clouds-taste.md b/.changeset/mighty-clouds-taste.md
@@ -0,0 +1,6 @@
+---
+'@graphql-tools/delegate': patch
+'@graphql-tools/utils': patch
+---
+
+enhance: avoid using globalThis
diff --git a/packages/batch-delegate/src/getLoader.ts b/packages/batch-delegate/src/getLoader.ts
@@ -61,10 +61,12 @@ const getLoadersMap = memoize3(function getLoadersMap<K, V, C>(
   return new Map<string, DataLoader<K, V, C>>();
 });
 
+const GLOBAL_CONTEXT = {};
+
 export function getLoader<K = any, V = any, C = K>(options: BatchDelegateOptions<any>): DataLoader<K, V, C> {
   const { schema, fieldName, context, info, dataLoaderOptions } = options;
   const targetFieldName = fieldName ?? info.fieldName;
-  const loaders = getLoadersMap<K, V, C>(context ?? globalThis ?? window ?? global, info.fieldNodes, schema);
+  const loaders = getLoadersMap<K, V, C>(context ?? GLOBAL_CONTEXT, info.fieldNodes, schema);
 
   let loader = loaders.get(targetFieldName);
 

diff --git a/packages/delegate/src/delegateToSchema.ts b/packages/delegate/src/delegateToSchema.ts
@@ -186,6 +186,8 @@ function validateRequest(delegationContext: DelegationContext<any>, document: Do
   }
 }
 
+const GLOBAL_CONTEXT = {};
+
 function getExecutor<TContext>(delegationContext: DelegationContext<TContext>): Executor<TContext> {
   const { subschemaConfig, targetSchema, context } = delegationContext;
 
@@ -194,7 +196,7 @@ function getExecutor<TContext>(delegationContext: DelegationContext<TContext>):
   if (subschemaConfig?.batch) {
     const batchingOptions = subschemaConfig?.batchingOptions;
     executor = getBatchingExecutor(
-      context ?? globalThis ?? window ?? global,
+      context ?? GLOBAL_CONTEXT,
       executor,
       batchingOptions?.dataLoaderOptions,
       batchingOptions?.extensionsReducer

diff --git a/packages/utils/src/AggregateError.ts b/packages/utils/src/AggregateError.ts
@@ -9,9 +9,9 @@ interface AggregateErrorConstructor {
   readonly prototype: AggregateError;
 }
 
-let AggregateErrorImpl: AggregateErrorConstructor = globalThis.AggregateError;
+let AggregateErrorImpl: AggregateErrorConstructor;
 
-if (typeof AggregateErrorImpl === 'undefined') {
+if (typeof AggregateError === 'undefined') {
   class AggregateErrorClass extends Error implements AggregateError {
     constructor(public errors: any[], message = '') {
       super(message);
@@ -22,6 +22,8 @@ if (typeof AggregateErrorImpl === 'undefined') {
   AggregateErrorImpl = function (errors: any[], message?: string) {
     return new AggregateErrorClass(errors, message);
   } as AggregateErrorConstructor;
+} else {
+  AggregateErrorImpl = AggregateError;
 }
 
 export { AggregateErrorImpl as AggregateError };