Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@graphql-tools/webpack-loader readme is only mentioning 2 of 6 options #3127

Open
Tracked by #5201 ...
jantimon opened this issue Jul 2, 2021 · 0 comments
Open
Tracked by #5201 ...
Assignees
Labels
docs Focuses on documentation changes

Comments

@jantimon
Copy link

jantimon commented Jul 2, 2021

according to the readme the loader provides only two options:

https://github.com/ardatan/graphql-tools/blob/3846041c14d0fe37d43b77156e2a0b85da8651ba/packages/webpack-loader/README.md

noDescription (default: false) - removes descriptions
esModule (default: false) - uses import and export statements instead of CommonJS

from the source:

interface Options {
noDescription?: boolean;
noEmptyNodes?: boolean;
noLoc?: boolean;
replaceKinds?: boolean;
esModule?: boolean;
importHelpers?: boolean;
}

could you please add jsdoc comments to those options and also add the missing options to the readme? :)

@ardatan ardatan added the docs Focuses on documentation changes label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

No branches or pull requests

3 participants