-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@graphql-tools/load
outputs debug logs for any value of DEBUG
#4777
Comments
also it breaks in our case
|
Hello, same here
I need |
I made a change to use |
Nice, thank you! |
Is there a work around to turn off the debugging until the fix is released? |
Has anyone found an alternative? This issue is almost 1 year old, and the Pull Request is left unmerged without any feedback from @ardatan. Are there anything we could do to help getting this fix merged and released? It's not just one or two debug lines… we have a project with lots of |
I had to delete |
Sorry for the late response! |
Issue workflow progress
Progress of the issue based on the Contributor Workflow
Describe the bug
@graphql-tools/load
prints debug logs ifprocess.env.DEBUG
is defined (even if empty, 0, or any value irrelevant to graphql-tools). This was introduced in #4752.When running
DEBUG=myapp node app.js
with any code that uses@graphql-tools/load
, debug logs are dumped into the console and also include incorrecttimeEnd
labels.To Reproduce
Steps to reproduce the behavior:
@graphql-tools/load
in yourapp.ts
DEBUG=myapp node app.js
, it will log things unrelated to your appExpected behavior
I expect
@graphql-tools/load
to only log when usingDEBUG=graphql-tools
(or any namespace of your choice), or only log when the DEBUG value is strictly1
(and nothing else) as per the original PR.I would expect the usage patterns of https://www.npmjs.com/package/debug, so it would only print when using
DEBUG=*
orDEBUG=graphql-tools
.Environment:
@graphql-tools/load
: 7.8.0The text was updated successfully, but these errors were encountered: