Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect properties #21

Closed
tlaundal opened this issue Sep 25, 2019 · 1 comment
Closed

Protect properties #21

tlaundal opened this issue Sep 25, 2019 · 1 comment

Comments

@tlaundal
Copy link
Contributor

  • Actions should be immutable: readonly
  • Action creators should have their type field properly immutable, readonly and defined with Object.defineProperty
@tlaundal
Copy link
Contributor Author

Also goes for decorated actionCreator created by namespace

@tlaundal tlaundal mentioned this issue Sep 25, 2019
Merged
This was referenced Nov 1, 2019
Closed
Merged
@tlaundal tlaundal added Blocked by Ardoq Stuff that is blocked by the cost of implementing them in Ardoq and removed Blocked by Ardoq Stuff that is blocked by the cost of implementing them in Ardoq labels Nov 6, 2019
@tlaundal tlaundal closed this as completed Nov 6, 2019
@tlaundal tlaundal mentioned this issue Nov 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make actions readonly and protected ardoq/rxbeach
1 participant
@tlaundal