feat: Refactor ActionWithPayload/ActionWithoutPayload to be uniform #605
Conversation
sseppola
force-pushed
the
feat/refactorActionType
branch
from
33b1927
to
7f155a5
Compare
sseppola
changed the title
| type ActionCreatorWithoutPayload_is_not_assibleable_to_UnknownActionCreatorWithPayload = | ||
| AssertFalse< | ||
| Has<ActionCreatorWithoutPayload, UnknownActionCreatorWithPayload<unknown>> | ||
| >; | ||
|
|
There was a problem hiding this comment.
This test case did not make sense.
| // Add letter representations to marble map | ||
| for (let i = 'A'.charCodeAt(0); i < 'Z'.charCodeAt(0); i++) { | ||
| const letter = String.fromCharCode(i); | ||
| marbleMap[letter] = letter; | ||
| } | ||
| // Add number representations to marble map | ||
| for (let i = 0; i < 10; i++) { | ||
| // Create marble representations of the 10 first characters | ||
| // eg. { A: 'A', B: 'B', ...etc } | ||
| const charCodeA = 'A'.charCodeAt(0); | ||
| const letter = String.fromCharCode(charCodeA + i); | ||
| marbleMap[letter] = letter; | ||
| // Create marble representations of the 10 first numbers from 0 | ||
| marbleMap[`${i}`] = i; | ||
| } |
There was a problem hiding this comment.
I had to change these tests because it was using the lengths of the action types.. which obviously changes when you enforce the ActionName type.
Now the tests are more robust.
| type ExtractPayload_extracts_payload2 = AssertTrue< | ||
| IsExact<ExtractPayload<ActionCreatorWithPayload>, void> | ||
| >; | ||
| // type aaa = ExtractPayload<VoidFn>; // weakness of ExtractPayload | ||
| // type aaa3 = ExtractPayload<unknown>; // weakness of ExtractPayload |
There was a problem hiding this comment.
InferPayloadFromActionCreator is the same as ExtractPayload, although a bit more flexible.
Thinking of renaming the former to the latter, so we use the most flexible version.
|
I don't think this is working correctly. |
|
@rafaa2 what's wrong with your screenshot? The actionCreator functions have a type attribute, and rxbeach relies on it. |
|
@sseppola But it should show ActionCreator not the whole object |
|
The type that appears is a function signature, so it is an action creator. |
|
@sseppola I am not talking about when you use the action creator, the new object should be displayed when you hover on it as ActionCreator instead of showing its shape: This: instead of: |
|
They are equivalent. Let's have a call tomorrow |
Co-authored-by: Rafaa <10600830+rafaa2@users.noreply.github.com>
| type ExtractPayload_extracts_payload = AssertTrue< | ||
| IsExact<ExtractPayload<ActionCreatorWithPayload<Payload>>, Payload> | ||
| >; | ||
| type ExtractPayload_extracts_payload2 = AssertTrue< |
There was a problem hiding this comment.
I love this form of documentation ❤️
sseppola
changed the title
No description provided.