Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVGL 9 release #834

Closed
dmazzella opened this issue Jan 30, 2024 · 3 comments · Fixed by #847
Closed

LVGL 9 release #834

dmazzella opened this issue Jan 30, 2024 · 3 comments · Fixed by #847
Labels
help wanted Extra attention is needed

Comments

@dmazzella
Copy link

The LVGL library has been updated to version 9 the changes from version 8 are in the changelog and Arduino IDE 2 warns of the new version release but Arduino_H7_Video library does not yet support the new display registration mode at the moment, what is your timeframe for the update?

Thanks

@facchinm
Copy link
Member

facchinm commented Feb 1, 2024

Hi @dmazzella ,
thanks for the heads up! I tried a quick 'n dirty porting, basic functionality is in place (see here and here ) but there's still work to be done due to the deprecation of sw_rotation flag (so Giga display shield only works in portrait mode).

@kisvegabor could you provide some insights on how the new lv_draw_sw_rotate API is supposed to work? The original draw_buf_rotate implementation is quite more sensitive on RAM (and transparent).

@leonardocavagnis since the plan is to release the core next week I'd proceed with adding an #error if LVGL_VERSION_MAJOR is 9, so at least there's a clean way to avoid the issues flood.

@facchinm facchinm added the help wanted Extra attention is needed label Feb 1, 2024
@kisvegabor
Copy link
Contributor

Hi @facchinm,

@kisvegabor could you provide some insights on how the new lv_draw_sw_rotate API is supposed to work? The original draw_buf_rotate implementation is quite more sensitive on RAM (and transparent).

It really required 2 separate source and destination buffers now. Note that the "original draw_buf_rotate implementation" from LVGL v8 was dynamically allocating a smaller temporary buffer for rotation.

The current implementation is

  • faster and cleaner
  • more explicit (there is no hidden allocation)
  • more flexible as you can provide any kind of destination buffer
  • you can rotate the source buffer line by line, so you need only one line for the destination buffer.

@leonardocavagnis
Copy link
Member

Dear @dmazzella,
LVGL v9 fix has been merged. It will be available in the next Core release.
Remember to update also the Arduino_GigaDisplayTouch library to version 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants