Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uno R4 minima] GPIO open drain mode select bug #343

Open
supertnt318 opened this issue Jun 14, 2024 · 1 comment
Open

[Uno R4 minima] GPIO open drain mode select bug #343

supertnt318 opened this issue Jun 14, 2024 · 1 comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@supertnt318
Copy link

supertnt318 commented Jun 14, 2024 •
edited by per1234
Loading

For uno minima, when configuring GPIO with pinMode() function, there is a bug when configured using OUTPUT_OPENDRAIN PinMode.

The fix would be to replace line:

ArduinoCore-renesas/cores/arduino/digital.cpp

Line 16 in 4e60678

R_IOPORT_PinCfg(NULL, g_pin_cfg[pin].pin, IOPORT_CFG_PORT_DIRECTION_OUTPUT | IOPORT_CFG_PMOS_ENABLE);

with:

#if UNO
R_IOPORT_PinCfg(NULL, g_pin_cfg[pin].pin, IOPORT_CFG_PORT_DIRECTION_OUTPUT | IOPORT_CFG_NMOS_ENABLE);
@per1234 per1234 transferred this issue from arduino/Arduino Jun 14, 2024
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 14, 2024
@rowingdude
Copy link

I opened a PR to address this.

@rowingdude rowingdude mentioned this issue Aug 7, 2024
Closed
@per1234 per1234 linked a pull request Aug 7, 2024 that will close this issue
Flip IOPORT_CFG_PMOS to _NMOS as needed #358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flip IOPORT_CFG_PMOS to _NMOS as needed
3 participants
@supertnt318 @per1234 @rowingdude