Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device-specific .h files do not match Renesas/User's Manual #354

Open
mziz opened this issue Jul 22, 2024 · 0 comments
Open

Device-specific .h files do not match Renesas/User's Manual #354

mziz opened this issue Jul 22, 2024 · 0 comments
Labels
type: imperfection Perceived defect in any part of project

Comments

@mziz
Copy link

mziz commented Jul 22, 2024

The header files (e.g. variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h) are out of date with the Renesas repository and are sometimes wrong.

For example, looking at the User's Manual "22.2.12 General PWM Timer Control Register (GTCR)" section, the bit offset for the TPCS field is 24. This matches the definition in the Renesas repo:

#define R_GPT0_GTCR_TPCS_Pos              (24UL)         /*!< TPCS (Bit 24)

However, the code in this repo is off by one:

https://github.com/arduino/ArduinoCore-renesas/blob/a430d9fbfcbea2ae293f842f211f1b5935ffdd90/variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h#L14441

 #define R_GPT0_GTCR_TPCS_Pos              (23UL)         /*!< TPCS (Bit 23)                                         */

Please update the device-specific headers in this repository to match the up to date Renesas headers.

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants