From 7e79dfd1f96e7a2523244e02bcd08b234fce3a09 Mon Sep 17 00:00:00 2001 From: Umberto Baldi <34278123+umbynos@users.noreply.github.com> Date: Thu, 16 May 2024 11:41:32 +0200 Subject: [PATCH] Bump actions/upload and actions/download (#952) * Bump actions/download-artifact from 3 to 4 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * Bump actions/download-artifact in new step * Bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * Bump actions/upload-artifact in new step * Migrate sync workflow to actions/[upload-download] to v4 See https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact --------- Signed-off-by: dependabot[bot] --- .../workflows/check-go-dependencies-task.yml | 2 +- .github/workflows/publish-go-tester-task.yml | 2 +- .github/workflows/release.yml | 24 +++++++++---------- .github/workflows/sync-labels.yml | 9 +++---- 4 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/workflows/check-go-dependencies-task.yml b/.github/workflows/check-go-dependencies-task.yml index 1d640ed4..4983e0db 100644 --- a/.github/workflows/check-go-dependencies-task.yml +++ b/.github/workflows/check-go-dependencies-task.yml @@ -105,7 +105,7 @@ jobs: # Some might find it convenient to have CI generate the cache rather than setting up for it locally - name: Upload cache to workflow artifact if: failure() && steps.diff.outcome == 'failure' - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error name: dep-licenses-cache diff --git a/.github/workflows/publish-go-tester-task.yml b/.github/workflows/publish-go-tester-task.yml index 5ba56a6f..66b38164 100644 --- a/.github/workflows/publish-go-tester-task.yml +++ b/.github/workflows/publish-go-tester-task.yml @@ -128,7 +128,7 @@ jobs: if: runner.os == 'macOS' - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: arduino-create-agent-${{ matrix.os }}${{ matrix.arch }} path: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 33fe2b7e..ce3caa1b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -147,7 +147,7 @@ jobs: if: steps.prerelease.outputs.IS_PRE != 'true' - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ env.PROJECT_NAME }}-${{ matrix.os }}-${{ matrix.arch }} path: | @@ -174,7 +174,7 @@ jobs: token: ${{ secrets.ARDUINO_CREATE_AGENT_CI_PAT }} - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ${{ env.PROJECT_NAME }}-macos-12-amd64 # if we want to support darwin-arm64 in the future for real this has to change. path: ${{ env.EXE_PATH }} @@ -218,7 +218,7 @@ jobs: run: tar -cvf ArduinoCreateAgent.app_${{ matrix.arch }}.tar -C skel/ . - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error name: ArduinoCreateAgent.app_${{ matrix.arch }} @@ -241,7 +241,7 @@ jobs: steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ArduinoCreateAgent.app_${{ matrix.arch }} @@ -356,7 +356,7 @@ jobs: if: ${{ needs.build.outputs.prerelease != 'true' }} - name: Upload artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized path: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip @@ -405,7 +405,7 @@ jobs: token: ${{ secrets.ARDUINO_CREATE_AGENT_CI_PAT }} - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ${{ env.PROJECT_NAME }}-${{ matrix.os }}-${{ matrix.arch }} path: artifacts/${{ matrix.platform-name }}/ # path expected by installbuilder @@ -429,7 +429,7 @@ jobs: if: matrix.os == 'ubuntu-20.04' - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ArduinoCreateAgent-${{ matrix.platform-name }}-${{ matrix.arch }} path: ArduinoCreateAgent* @@ -456,7 +456,7 @@ jobs: steps: - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ArduinoCreateAgent-windows-${{ matrix.arch }} @@ -472,7 +472,7 @@ jobs: "${{ env.SIGNTOOL_PATH }}" sign -d "Arduino Create Agent" -f ${{ env.INSTALLER_CERT_WINDOWS_CER}} -csp "eToken Base Cryptographic Provider" -k "[{{${{ env.CERT_PASSWORD }}}}]=${{ env.CONTAINER_NAME }}" -fd sha256 -tr http://timestamp.digicert.com -td SHA256 -v "ArduinoCreateAgent-${GITHUB_REF##*/}-windows-${{ matrix.arch }}-installer.exe" - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error name: ArduinoCreateAgent-windows-${{ matrix.arch }}-signed @@ -494,7 +494,7 @@ jobs: token: ${{ secrets.ARDUINO_CREATE_AGENT_CI_PAT }} - name: Download artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized path: ArduinoCreateAgent.app @@ -570,7 +570,7 @@ jobs: run: tar -cvf ArduinoCreateAgent-${GITHUB_REF##*/}-osx-${{ matrix.arch }}-installer.tar ArduinoCreateAgent-${GITHUB_REF##*/}-osx-${{ matrix.arch }}-installer.dmg - name: Upload artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ArduinoCreateAgent-osx-${{ matrix.arch }} path: ArduinoCreateAgent*.tar @@ -588,7 +588,7 @@ jobs: fetch-depth: 0 # fetch all history for the create changelog step to work properly - name: Download artifact - uses: actions/download-artifact@v3 # download all the artifacts + uses: actions/download-artifact@v4 # download all the artifacts # mandatory step because upload-release-action does not support multiple folders - name: prepare artifacts for the release diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index d0a55352..184a4207 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -71,13 +71,13 @@ jobs: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} - name: Pass configuration files to next job via workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: path: | *.yaml *.yml if-no-files-found: error - name: ${{ env.CONFIGURATIONS_ARTIFACT }} + name: ${{ env.CONFIGURATIONS_ARTIFACT }}-${{ matrix.filename }} sync: needs: download @@ -109,10 +109,11 @@ jobs: uses: actions/checkout@v4 - name: Download configuration files artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: - name: ${{ env.CONFIGURATIONS_ARTIFACT }} + pattern: ${{ env.CONFIGURATIONS_ARTIFACT }}-* # Download all configuration files path: ${{ env.CONFIGURATIONS_FOLDER }} + merge-multiple: true - name: Remove unneeded artifact uses: geekyeggo/delete-artifact@v5