Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog text invisible when using "High Contrast (Theia)" theme #1061

Closed
3 tasks done
per1234 opened this issue Jun 14, 2022 · 0 comments · Fixed by #1092
Closed
3 tasks done

Changelog text invisible when using "High Contrast (Theia)" theme #1061

per1234 opened this issue Jun 14, 2022 · 0 comments · Fixed by #1092
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jun 14, 2022

Describe the problem

The Arduino IDE automatically checks for availability of a newer version on startup. If one is available, a "Software Update" dialog is shown which includes a changelog.

🐛 If the user is using the "High Contrast (Theia)" theme, the text of the changelog is invisible.

image

To reproduce

  1. Configure the Arduino IDE to offer an update. This will be most easy to accomplish by using an outdated version of the IDE.
    That need not be outdated in a significant manner if you have the "Arduino › Ide: Update Channel" (arduino.ide.updateChannel) advanced setting set to "nightly".
    Alternatively, you can simulate an outdated condition in any IDE version by using the testing system described here: Add preference to set a custom update url #865
  2. Select File > Preferences... from the Arduino IDE menus.
  3. Select "High Contrast (Theia)" from the "Theme" menu.
  4. Click the OK button.
  5. Select File > Quit from the Arduino IDE menus.
  6. Start the Arduino IDE.

🐛 The text of the changelog shown in the "Software Update" dialog is invisible.

Expected behavior

Changelog uses the theme colors.

- OR -

Changelog uses a fixed color scheme (e.g., black text on white background).

Arduino IDE version

2.0.0-rc7-snapshot-a804766

Operating system

Windows

Operating system version

10

Additional context

It seems the problem is that the changelog background color does not follow the theme, while the changelog text does.


Although still readable, the contrast is also quite low when using the "Dark (Arduino)" and "Dark (Theia)" themes.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 14, 2022
@francescospissu francescospissu linked a pull request Jun 21, 2022 that will close this issue
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jun 21, 2022
@per1234 per1234 added the topic: theme Related to GUI theming label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants