Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with "Peek Declaration" and "Peek Definition" also with "Go To ..." #138

Closed
sstaub opened this issue Oct 21, 2019 · 3 comments
Closed
Assignees
Labels
conclusion: duplicate Has already been submitted criticality: low Of low impact topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project

Comments

@sstaub
Copy link

sstaub commented Oct 21, 2019

Describe the bug
There is a bug with "Peek Declaration" and "Peek Definition"
"Peek Declaration" does nothing!
"Peek Definition" shoes the declaration of functions instead of their definition
The same happens with "Go To...

To Reproduce
Steps to reproduce the behavior:

  1. Open Blink example
  2. right click on digitalWrite and select "Peek Declaration" -> noting happens
  3. right click on digitalWrite and select "Peek declaration" -> it shows the declaration in common.h

Expected behavior
It should work like in VSC, in this example

  • "Peek Declaration" should show the declaration of the function in common.h
  • "Peek Definition" should show the definition of the function in wiring_digital.c

Screenshots

  • Peek Definition in Arduino IDE

peek definition Arduino IDE

  • Peek Definition in VSC

peek definition in VSC

Desktop (please complete the following information):

  • macOS Catalina
  • Version 0.0.1
@rsora rsora transferred this issue from arduino/arduino-pro-ide Mar 1, 2021
@rsora rsora added the priority: low Resolution is a low priority label Mar 1, 2021
@mink99

This comment was marked as off-topic.

@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added type: imperfection Perceived defect in any part of project topic: language server Related to the Arduino Language Server labels Sep 22, 2021
@rsora rsora added criticality: low Of low impact and removed priority: low Resolution is a low priority labels Nov 2, 2021
@per1234
Copy link
Contributor

per1234 commented Nov 28, 2021

"Peek Declaration" does nothing!

This non-functional feature has been removed.

right click on digitalWrite and select "Peek declaration" -> it shows the declaration in common.h

This issue is board-specific. For example, I am able to reproduce it with the "Arduino MKRZERO" board, but not with "Arduino Uno".

Note that the megaavr architecture is not supported at all now (#31), so you will no longer get the described results with the "Arduino Nano Every" board selected.

@per1234 per1234 assigned per1234 and unassigned cmaglie Mar 20, 2024
@per1234
Copy link
Contributor

per1234 commented Mar 20, 2024

As I mentioned above, the non-functional "Peek Declaration" feature was removed (#1394). We are tracking the need to implement this feature at arduino/arduino-language-server#156.

This leaves one other bug report that was mashed into this issue:

"Peek Definition" shoes the declaration of functions instead of their definition
The same happens with "Go To...

We are now tracking that in the higher quality issue arduino/arduino-language-server#167 so I will close this one as a duplicate.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted criticality: low Of low impact topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

7 participants