Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to close split tabs #552

Closed
BanksySan opened this issue Oct 14, 2021 · 19 comments · Fixed by #940
Closed

Unable to close split tabs #552

BanksySan opened this issue Oct 14, 2021 · 19 comments · Fixed by #940
Assignees
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@BanksySan
Copy link

BanksySan commented Oct 14, 2021

Describe the bug
Ctrl + \ splits the view horizontally and opens a duplicate tab in the new section.

There's no way to close the split views though, even closing the IDE doesn't fix it as it remembers your last layout and helpfully opens up in the state you left it.

To Reproduce
Steps to reproduce the behavior:

  1. Open project.
  2. Split screen with Ctrl + \.

Expected behavior
There's a method to close views.

Screenshots

image

Desktop (please complete the following information):
Edition Windows 10 Home
Version 21H1
OS build 19043.1288
Experience Windows Feature Experience Pack 120.2212.3920.0

Additional context

IDE:

Version 2.0.0-beta.12
Date 2021-10-07T07:55:54.325Z
CLI Version 0.19.1 alpha [718bbbf2]

@BanksySan BanksySan added the type: imperfection Perceived defect in any part of project label Oct 14, 2021
@CptHolzschnauz
Copy link

CptHolzschnauz commented Oct 15, 2021

It's a fantastic feature.

A 'Close Tab' in the dropdown is needed. That's all. Delete is not needed. Who wants to delete a sketch this way so often that it needs his own dropdown entry?

Suggestion: Substitute "Delete" with "Close"

@per1234
Copy link
Contributor

per1234 commented Oct 15, 2021

Who wants to delete a sketch this way so often that it needs his own dropdown entry?

You're right that it's not worth having this menu item for deleting a sketch. That's not the reason for the menu item's existence though. The sketch deletion capability is only about getting a little extra functionality out of an existing UI element. The reason for the menu item's existence is to allow deletion of secondary sketch files (shown as tabs in the IDE). Adding and removing secondary sketch tabs is a more common need for the IDE user as tabs are used to organize the sketch code.

The suggestion to add a "Close" item to the tab control menu is reasonable though. However, this is a departure from the current UI convention for closing non-required tabs (e.g., File > Advanced > Keyboard Shortcuts), which is the more visible and intuitive X icon to the right side of the tab text.

@CptHolzschnauz
Copy link

I don't get the UX concept here. When i press delete, a dialogue ask me if i want to delete the sketch (Move file to trash),
i can't imagine a working concept that is using this item regulary.

Anyway, a visible x icon would be also fine to close ordinary tabs or splitted windows, just something to close tabs is IMHO absolut neccesary.

I also don't see a departure from the current UI convention whith a 'Close Tab' in the dropdown of each sketch tab because these are user files, while the "system files" (eg Keyboard Shortcuts) have an X.

PS: I use normally Visual Studio Code with IMHO perfect handling of the tab/split view etc. theme.
Why reinventing the wheel when there is a solid UX role model used and shaped by million of users?
From my personal perspective, the smooth and lean handling of files with the seperated SplitViewButton on top right in VSC is a main reason for me to use this editor. I often work with three tabs on the same file so i don't have to scroll around, i add a long line to seperate code. These long lines are easy to spot with the minitab view on the right.
These two features and a good search function in the serial monitor would be fine for me...
Huch..i justed checked: Is there no search function in the serial monitor? I

@BanksySan
Copy link
Author

BanksySan commented Oct 16, 2021

As things are, any suggestion on how I get rid of the tabs I have open?

image

Keyboard shortcut

The suggestion to add a "Close" item to the tab control menu is reasonable though. However, this is a departure from the current UI convention for closing non-required tabs (e.g., File > Advances > Keyboard Shortcuts), which is the more visible X icon to the right side of the tab text.

The keyboard shortcuts have several entries for closing tabs, none of them work though, the tabs stubbornly stay where they are.

image

@per1234
Copy link
Contributor

per1234 commented Oct 16, 2021

any suggestion on how I get rid of the tabs I have open?

You can reset the IDE by deleting this folder on Windows:

C:\Users\<user name>\AppData\Roaming\arduino-ide

@per1234 per1234 added the topic: code Related to content of the project itself label Oct 16, 2021
@skypanther
Copy link

I'm having the same issue as the original submitter, though I'm working on a Mac running Big Sur. Deleting a config file as per1234 suggests might work, but is hardly a good solution.

I'm not sure why you hide the X in the tab that VSCode usually provides. You've also removed the View: Split Editor Single command which closes all the split windows. You hide the View menu. I'm actually dumbfounded how many unnecessary changes from VSCode have been made to create this IDE.

@per1234
Copy link
Contributor

per1234 commented Nov 14, 2021

Deleting a config file as per1234 suggests might work, but is hardly a good solution.

I apologize if I somehow gave the impression it was a solution. It is only a workaround. The Arduino IDE developers will close this issue once there is a solution.

unnecessary changes from VSCode

Arduino IDE 2.x is built on the open source Eclipse Theia framework, not VS Code. Since they are based on some of the same technologies and design philosophies, there are some resemblances to VS Code, but they are not the same. Arduino IDE 2.x is not a variant of VS Code. Arduino IDE 2.x is its own project and Arduino has its own vision for that project. If you want to participate in a positive manner in making that vision a reality, you are welcome. If you have some other vision, then feel free to make your own IDE.

@ch4bes
Copy link

ch4bes commented Feb 13, 2022

I've found that I'm able to close unwanted split panes using the Explorer sidebar, where it shows "OPEN EDITORS". Each instance has an "X" on the right side that can be used to close it.

Would still be nice to have a way of closing the panes from the editor itself, in addition to a keyboard shortcut.

Edit: wanted to mention I'm using 2.0.0.-rc3

@per1234
Copy link
Contributor

per1234 commented Feb 13, 2022

The bug is more serious since #791 because the split editor capability is now accessible via the primary UI:

image

@ubidefeo ubidefeo added this to the arduino-ide rc5 milestone Feb 17, 2022
@ubidefeo ubidefeo added the criticality: medium Of moderate impact label Feb 17, 2022
@michael-vrba
Copy link

image

@kittaakos kittaakos mentioned this issue Mar 14, 2022
3 tasks
@mudgalp
Copy link

mudgalp commented Mar 19, 2022

this worked for me..
Thank you

@road-t
Copy link

road-t commented Mar 23, 2022

That's INSANE not to have close tab button. I had to remove the settings db to get rid of 5 split windows (erroneously pushed cmd + \ instead of cmd + /). That is ridiculous.

@fstasi fstasi modified the milestones: arduino-ide rc5, arduino-ide rc6 Mar 24, 2022
@ch4bes
Copy link

ch4bes commented Mar 26, 2022

Pressing cmd + \ instead of cmd + / is how I found out about this issue as well. Simple (and probably quite common) mistake.

@fstasi fstasi assigned msujew and unassigned fstasi Apr 1, 2022
@fstasi
Copy link
Contributor

fstasi commented Apr 1, 2022

@msujew we decided to disable split tabs at all for now

@road-t
Copy link

road-t commented Apr 1, 2022

@msujew we decided to disable split tabs at all for now

facepalm

@per1234
Copy link
Contributor

per1234 commented Apr 1, 2022

Hi all. Let's keep this issue focused on the original subject, which is the current inability to close split editors. Disabling the feature that is not working properly is the planned mitigation measure for this specific issue.

We will dedicate #909 to tracking the request for adding a fully functional split editor capability.

Any discussion about that should be done over there, and I will request that people only comment there if you have something constructive to add. If you only want to express general support or disagreement, then use the Reactions feature so that we don't generate a bunch of noise for the people who are watching the repository in order to keep up with the development work.

@per1234 per1234 added the conclusion: resolved Issue was resolved label Apr 6, 2022
@numeralz
Copy link

numeralz commented Apr 20, 2022

@per1234
@fstasi

Guys, I'm so sorry, but I was sooo excited that Arduino IDE has migrated to something that resembles VSCode, but this issue is simply puzzling.

Certainly, integrating the open-source vs-code IDE interface had the close tab functionality already working, it is not like this feature is in development.. on the contrary: effort was expended to remove basic functionality that is intuitive and expected to work. Why?

Having to google to look up how to close a tab that I accidentally split 3 times is insane, and confusing to hobbyists, both new and experienced.

I just don't understand, because the customization to remove an existing feature must have been intentionally planned, and then developer time allocated to make this customization happen. It puzzles me - why was it so important this feature be disabled? Do newbies accidentally close tabs too often, and then complain about it, that it was deemed necessary to disable the close tab button, middle-click to close, and even disable any keyboard shortcuts from closing tabs?? And now splitting tabs is planned to be removed too? I would hate to see the VS-Code IDE experience get stripped down to the level of MS Notepad..

I even accidentally "deleted" my file because I thought this was the new close button.

Aside from this, I am extremely excited about the new IDE and think it has insanely great potential to improve the development workflow on the platform. Hats off to everyone working on this.

@Zechs2205
Copy link

This issue still persists. Get your shit together like wtf is this. I cant even F1 and find close. Its on me for using your shitty IDE

@michael-vrba
Copy link

Yes, I agree. How can they program the programming interface if they can't split the window and allow it to close/collapse. They solve the problem by disabling the option. Two years ago!

@arduino arduino locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.