Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another problem with hot module replacement (npm run twill-dev) #267

Closed
plexus77 opened this issue May 15, 2019 · 3 comments
Closed

Another problem with hot module replacement (npm run twill-dev) #267

plexus77 opened this issue May 15, 2019 · 3 comments

Comments

@plexus77
Copy link

plexus77 commented May 15, 2019

Hi there, I am running a twill dev environment on homestead and running npm/yarn from my computer itself... The scripts and styles are available eg localhost:8080/assets/admin/css/app.css, however the hot module replacement is not working and is throwing a JS error Invalid Host/Origin header when the socket trys to connect.

To get it working I needed to add the following lines into the mix.webpackConfig inside /vendor/area17/twill/webpack.mix.js

  devServer: {
    disableHostCheck: true
  }

webpack/webpack-dev-server#1604

@yanhao-li
Copy link

Hi @plexus77 ,

Thank you for reporting this! Similar issue and discussion are here: #152
add -disable-host-check to hot script can also fix such issue.

@ifox
Copy link
Member

ifox commented May 31, 2019

Hi guys,

this is fixed in our upcoming release, stay tuned!

@ifox
Copy link
Member

ifox commented Aug 21, 2019

Fixed in 1.2.2.

@ifox ifox closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants