Add Jest for tests #1391
Closed
Add Jest for tests #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
commented
Aug 3, 2018
| @@ -141,5 +143,8 @@ | |||
| }, | |||
| "optionalDependencies": { | |||
| "fsevents": "*" | |||
| }, | |||
| "jest": { | |||
| "testURL": "http://localhost" | |||
There was a problem hiding this comment.
Can remove this once this patch is published. JSDom (used underneath Jest) made a change upstream and broke libs all across the internet.
|
Cool I'm with it. Will just add swap out Mocha in my branch and co-locate my spec for that other fn instead of dealing with this merge. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #1390 that some tests were starting to get written so wanted to suggest Jest before things got too far along. This lib is really futuristic as far as test runners go and is basically zero config. It looks for files with a
file.test.jsextension (or files placed in a__tests__directory) so you can very easily co-locate tests alongside their sources which tends to dramatically increase test-coverage over time since everything is side-by-side.(Also, not sure if you've used Enzyme before but it's great for writing component tests and works nicely with Jest.)