Skip to content

Commit

Permalink
FIX-modin-project#1857: make 'sort_index' consider axis parameter (mo…
Browse files Browse the repository at this point in the history
…din-project#1858)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
  • Loading branch information
dchigarev authored and aregm committed Sep 16, 2020
1 parent 45b1bb8 commit df3f1d4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions modin/backends/pandas/query_compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1562,6 +1562,7 @@ def sort_index(self, **kwargs):
):
return self.default_to_pandas(
pandas.DataFrame.sort_index,
axis=axis,
level=level,
sort_remaining=sort_remaining,
**kwargs
Expand Down
8 changes: 8 additions & 0 deletions modin/pandas/test/test_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -5970,11 +5970,19 @@ def test_sort_index(self, data, axis, ascending, na_position, sort_remaining):
pandas_df.index = pandas.MultiIndex.from_tuples(
[(i // 10, i // 5, i) for i in range(len(pandas_df))]
)
modin_df.columns = pd.MultiIndex.from_tuples(
[(i // 10, i // 5, i) for i in range(len(modin_df.columns))]
)
pandas_df.columns = pd.MultiIndex.from_tuples(
[(i // 10, i // 5, i) for i in range(len(pandas_df.columns))]
)

with pytest.warns(UserWarning):
df_equals(modin_df.sort_index(level=0), pandas_df.sort_index(level=0))
with pytest.warns(UserWarning):
df_equals(modin_df.sort_index(axis=0), pandas_df.sort_index(axis=0))
with pytest.warns(UserWarning):
df_equals(modin_df.sort_index(axis=1), pandas_df.sort_index(axis=1))

@pytest.mark.parametrize("data", test_data_values, ids=test_data_keys)
@pytest.mark.parametrize("axis", axis_values, ids=axis_keys)
Expand Down

0 comments on commit df3f1d4

Please sign in to comment.