Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pi-hole switch always in 'off' mode. #46

Closed
PatriceRobert opened this issue Jan 9, 2022 · 10 comments
Closed

[BUG] Pi-hole switch always in 'off' mode. #46

PatriceRobert opened this issue Jan 9, 2022 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@PatriceRobert
Copy link

Pi-hole switch always in position 'Off' in homekit.

Steps to reproduce the behavior:

  1. Pi-hole switch showing 'Off' on the home app
  2. Click to turn it on
  3. Check it is really 'On' under the Pi-hole console (check both states)
  4. quit and re-connect to the home app
  5. Pi-hole switch is 'Off'

The actions are well executed via API so connection is ok, API key is correct and working fine, the only issue is to see the Pi-hole switch back to 'Off' all the time.
This is happening since the latest Pi-hole update running under docker:

  • Docker Tag 2022.01.1
  • Pi-hole v5.8.1
  • FTL v5.13
  • Web Interface v5.10.1
  • MacOS 12.1 / iOS 15.2

No a big issue as it's still working but annoying as we cannot get the correct state and it can break some automations.

@PatriceRobert PatriceRobert added the bug Something isn't working label Jan 9, 2022
@PatriceRobert PatriceRobert changed the title [BUG] [BUG] Pi-hole switch always in 'off' mode. Jan 9, 2022
@arendruni
Copy link
Owner

Hi @PatriceRobert, you're not the only reporting this issue as other users are experiencing this bug with the latest pi-hole versions.
I investigated and found out that the plugins is working as expected, in fact the bug is on the pi-hole admin: the status request used by the plugin is always returning {"status":"disabled"}. See pi-hole/web#2051 for more informations, a fix will be added in their next release.

I am leaving this issue open as a spike.

@jamie-2bit
Copy link

jamie-2bit commented Jan 23, 2022

Yes, finding this is the case also on Pi-hole v5.8.1 FTL v5.13 Web Interface v5.10.1 & homebridge-pihole v0.4.1

@AquaRelliux
Copy link

haha I just spent 1-2 hours trying to get this to work my toggle was always set to disabled even though pihole was enabled. I am guessing this bug is still active? Because otherwise this is not working at all for me it works in homeassistant with their plugin flawlessly but I am trying to go away from homeassistant because it is just to much hassle to get it to work

@g6nhu
Copy link

g6nhu commented Jan 30, 2022

I rebuilt my homebridge as hoobs this morning and have spent hours trying to sort this!

@AquaRelliux
Copy link

I rebuilt my homebridge as hoobs this morning and have spent hours trying to sort this!

Ye it sucks it works perfect in homeassistant though so I guess it is coded better in there

@jamie-2bit
Copy link

jamie-2bit commented Feb 1, 2022

Here's the update from the PiHole release team:

pi-hole/web#2051

Soon-ish™

But really, it all depends on when we can align ourselves to get a release prepped and pushed out. We (the folk that press all the buttons) all live in different parts of the world, so it can be tricky to tie down a time sometimes.

The fix will be in the next release, but I can't tell you at this point in time when that next release will be without being as vague as Soon.

@rloomans
Copy link
Contributor

rloomans commented Feb 5, 2022

I've created a pull request that works around the Pihole bug: #49

@arendruni
Copy link
Owner

arendruni commented Feb 7, 2022

Hi everyone, and thank for the support!
I've just released a beta version 0.4.2-beta.1 with @rloomans patch using the main API, the different endpoint introduced by #49, seems to cache the old status value for 15-20 seconds before updating it, so I'm keeping this in beta before releasing to the main channel, probably next week.

@vinaydawani
Copy link

I had been running the same issue but it seems to be fixed in Pi-hole v5.9 FTL v5.14 Web Interface v5.11

Here's the update from admin thread

@arendruni
Copy link
Owner

I can confirm the plugin is working correctly again on Pi-hole v5.9 FTL v5.14 Web Interface v5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants