Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified configuration for ir-full, tasmota-ircustom no more needed #12428

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

s-hadinger
Copy link
Collaborator

Description:

Simplified configuration for IR. Now IR-full is done directly with ifdefs and does not need CLI options:

  • removed tasmota-ircustom which is no more needed
  • packaged IRremoteESP8266 in a subdirectory to avoid changing library.json when updating library version

WARNING: Platform.io fails to detect changes in ifdefs, so if you change any IR configuration, you need to clear the .cache directory.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

"build": {
"srcDir": "IRremoteESP8266/src",
"flags": [ "-I$PROJECT_DIR/include", "-includetasmota_options.h" ]
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this addition to the default library we need to make sure it is appended with any library update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I pushed the entire library one directory below. You shouldn't change this file, and only update teh content of the subdirectory also named IRremoteESP8266

@arendst arendst merged commit 381100d into arendst:development Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants