Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Platformio and fix override use #12442

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

Jason2866
Copy link
Collaborator

Description:

with the change how override is done now, some redundant can be removed. No need for entry [common32] anymore
Regression fixed in override that build_flags changes where not used.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866 Jason2866 closed this Jun 22, 2021
@Jason2866 Jason2866 reopened this Jun 22, 2021
@arendst arendst merged commit e102d4e into arendst:development Jun 22, 2021
@Jason2866 Jason2866 deleted the fix_override branch June 22, 2021 18:16
@Jason2866 Jason2866 restored the fix_override branch June 23, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants