Add IP filter to TCPStart command #12806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is an optional second parameter to enable some very basic security around the
TCPStart
command. I run Home Assistant with the ZHA integration using the TCP Serial feature. The HTTP interface can be protected with a password and MQTT uses authentication, but there's no security measures on the TCP Serial bits. Of course there's no protocol to add authentication as such, but old NFS relied upon host-based security and it seems harmless to implement.I'll update the docs as well, but I thought it best to see your thoughts as well beforehand.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass