Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP filter to TCPStart command #12806

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Add IP filter to TCPStart command #12806

merged 1 commit into from
Aug 1, 2021

Conversation

jamesorlakin
Copy link

Description:

This is an optional second parameter to enable some very basic security around the TCPStart command. I run Home Assistant with the ZHA integration using the TCP Serial feature. The HTTP interface can be protected with a password and MQTT uses authentication, but there's no security measures on the TCP Serial bits. Of course there's no protocol to add authentication as such, but old NFS relied upon host-based security and it seems harmless to implement.

I'll update the docs as well, but I thought it best to see your thoughts as well beforehand.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7.3 (I don't have ESP32 hardware)
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

This is an optional second parameter to enable some very basic security.
@arendst arendst merged commit ca91dea into arendst:development Aug 1, 2021
@s-hadinger
Copy link
Collaborator

Thanks for your PR. Indeed there was no security on the TCP connection.

Looks good to me. @arendst

blakadder pushed a commit to tasmota/docs that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants