Ethernet IP Config #14385

barbudor · 2022-01-11T19:13:30Z

Description:

Following multiple discussions this PR introduces full support for Ethernet IP configuration independently of Wifi

New commands dedicated to Ethernet
- EthIpAddress
- EthGateway
- EthSubnetmask (aligned to D_JSON_SUBNETMASK)
- EthDNSServer[1|2]
- Configuration saved in dedicated Setting area only for ESP32 (excluding C3/S2)
Update Status 5 with separated details for Wifi (legacy) and Ethernet

{
    "StatusNET":{
        "Hostname":"myesp","IPAddress":"192.168.168.51","Gateway":"192.168.168.254","Subnetmask":"255.255.255.0",
        "DNSServer1":"192.168.168.244","DNSServer2":"1.1.1.1","Mac":"F0:08:D1:F7:B9:D0",
        "EthHostname":"myesp-eth","EthIPAddress":"192.168.100.100","EthGateway":"192.168.100.1","EthSubnetmask":"255.255.255.0",
        "EthDNSServer1":"1.1.1.1","EthDNSServer2":"8.8.8.8","EthMac":"12:34:56:78:9A:BC",
        "Webserver":2,"HTTP_API":1,"WifiConfig":5,"WifiPower":17.0
    }
}

Update the INFO2 Message

{
    "Info2":{
        "WebServerMode":"Admin","Hostname":"myesp","IPAddress":"192.168.168.51",
        "EthHostname":"myesp-eth","EthIPAddress":"192.168.100.100"
    }
}

Add rules events
- on Eth#Connected do
- on Eth#Disconnected do

Checklist:

The pull request is done against the latest development branch
Only relevant files were touched
Only one feature/fix was added per PR and the code change compiles without warnings
The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
The code change is tested and works with Tasmota core ESP32 V.2.0.2
I accept the CLA.

s-hadinger

Great PR. Just a remark about possible use of a prefix for all Eth commands

s-hadinger · 2022-01-11T19:37:55Z

tasmota/xdrv_82_esp32_ethernet.ino

+#define D_CMND_ETHIPADDRESS "Eth" D_CMND_IPADDRESS
+#define D_CMND_ETHGATEWAY   "Eth" D_JSON_GATEWAY
+#define D_CMND_ETHNETMASK   "Eth" D_JSON_SUBNETMASK
+#define D_CMND_ETHDNS       "Eth" D_JSON_DNSSERVER

 const char kEthernetCommands[] PROGMEM = "|"  // No prefix


You can actually use "Eth" as prefix before the first "|"

I'll do in a minute
Is there also an way got extract a sub command to avoid the array below?

arendst · 2022-01-12T11:04:59Z

tasmota/settings.h

-    uint16_t spare11 : 1;
-    uint16_t spare12 : 1;
+    uint16_t eth_connected : 1;
+    uint16_t eth_disconnected : 1;
    uint16_t spare13 : 1;


There is an issue with shutters here. I don't like the shutter solution and I will see if this can be solved first to merge your PR.

In short, ifdef USE_SHUTTERS changes the amount of bits tested based on the assumptions the last two bits are for shutter status. This changes with your implemntation.

The bits are not persistent so I suggest the following:

Insert your entries just above the http_init bit.

Increment both MAX_RULES_FLAG by two.

Update RulesEvery50ms() by insert your rule text above the HTTP entries. So they become 8 and 9. HTTP becomes 10 and the optional shutter ones become 11 and 12.

arendst · 2022-01-12T11:14:43Z

tasmota/settings.h

  uint8_t       free_ea6[32];              // EA6
+#endif


I see your point but this results in issues in the future where these bits are used for all processor types. I suggest to move it to the 32-bit register area at the bottom just above F9C and reserve it fixed for all processor types. No ifdefs needed.

arendst · 2022-01-12T14:14:09Z

Latest update as of 20220115-15:15

I will make the changes to this PR and implement it like you did solving some issues on the way.

Pls hold on and do not make any changes to this PR anymore.

Phase 1 Ethernet IP address config (#14385) - Currently unable to change DNS servers

Phase 2 of 2 Ethernet IP address config based on PR (#14385)

Add commands for ESP32 ethernet configuration ``EthIpAddress``, ``EthGateway``, ``EthSubnetmask``, ``EthDnsServer1`` and ``EthDnsServer2`` (#14385)

arendst · 2022-01-13T14:37:16Z

This has been implemented today.

barbudor · 2022-01-13T19:51:46Z

Thanks Theo

labmaster · 2022-01-31T22:43:01Z

@barbudor

Description:

Following multiple discussions this PR introduces full support for Ethernet IP configuration independently of Wifi
* New commands dedicated to Ethernet
  
  * `EthIpAddress`
  * `EthGateway`
  * `EthSubnetmask`  (aligned to D_JSON_SUBNETMASK)
  * `EthDNSServer[1|2]`
  * Configuration saved in dedicated Setting area only for ESP32 (excluding C3/S2)
...

i can t get EthDNSServer1 and /or EthDNSServer2 set.

IP, Gateway and Subnetmask can be set, and then correctly shown in the "Main Menu"->"Information" Tab, but not the DNS ServerIP, they always stay at 0.0.0.0 there.

Any hint ?

Thanks, Walter

barbudor · 2022-01-31T23:23:29Z

I'm not sure the PR covered the web GUi
Please open an issue filling all required details

screenshots of the problematic screens
Thanks

barbudor added 3 commits January 11, 2022 00:33

ethernet config step 1

deb61aa

eth ipconfig 2nd step

77c0bf3

eth 3rd step adding rules events

8c2c610

s-hadinger approved these changes Jan 11, 2022

View reviewed changes

optimise command array

77f5e07

arendst reviewed Jan 12, 2022

View reviewed changes

arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Jan 12, 2022

arendst reviewed Jan 12, 2022

View reviewed changes

arendst added the awaiting feedback Action - Waiting for response or more information label Jan 12, 2022

arendst self-assigned this Jan 12, 2022

arendst removed the awaiting feedback Action - Waiting for response or more information label Jan 12, 2022

arendst added a commit that referenced this pull request Jan 12, 2022

Phase 1 Ethernet IP address config

04a4a65

Phase 1 Ethernet IP address config (#14385) - Currently unable to change DNS servers

arendst added a commit that referenced this pull request Jan 13, 2022

Phase 2/2 Ethernet IP address config

e6e5d51

Phase 2 of 2 Ethernet IP address config based on PR (#14385)

arendst added a commit that referenced this pull request Jan 13, 2022

Fix ESP8266 compilation

5c73fef

Add commands for ESP32 ethernet configuration ``EthIpAddress``, ``EthGateway``, ``EthSubnetmask``, ``EthDnsServer1`` and ``EthDnsServer2`` (#14385)

arendst closed this Jan 13, 2022

barbudor deleted the eth_settings branch January 13, 2022 19:51

barbudor mentioned this pull request Jan 14, 2022

ESP32 with wired LAN and PoE #8503

Closed

labmaster mentioned this pull request Feb 1, 2022

When trying #14385, EthDNSServer1 and EthDNSServer2 not correctly shown in Tasmota Web UI "Information" #14688

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ethernet IP Config #14385

Ethernet IP Config #14385

barbudor commented Jan 11, 2022 •

edited

Loading

s-hadinger left a comment

s-hadinger Jan 11, 2022

barbudor Jan 11, 2022

arendst Jan 12, 2022

arendst Jan 12, 2022

arendst Jan 12, 2022

arendst commented Jan 12, 2022

arendst commented Jan 13, 2022

barbudor commented Jan 13, 2022

labmaster commented Jan 31, 2022 •

edited

Loading

Description:

barbudor commented Jan 31, 2022

Ethernet IP Config #14385

Ethernet IP Config #14385

Conversation

barbudor commented Jan 11, 2022 • edited Loading

Description:

Checklist:

s-hadinger left a comment

Choose a reason for hiding this comment

s-hadinger Jan 11, 2022

Choose a reason for hiding this comment

barbudor Jan 11, 2022

Choose a reason for hiding this comment

arendst Jan 12, 2022

Choose a reason for hiding this comment

arendst Jan 12, 2022

Choose a reason for hiding this comment

arendst Jan 12, 2022

Choose a reason for hiding this comment

arendst commented Jan 12, 2022

arendst commented Jan 13, 2022

barbudor commented Jan 13, 2022

labmaster commented Jan 31, 2022 • edited Loading

Description:

barbudor commented Jan 31, 2022

barbudor commented Jan 11, 2022 •

edited

Loading

labmaster commented Jan 31, 2022 •

edited

Loading