Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry add bytes().setbytes() #16892

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Conversation

s-hadinger
Copy link
Collaborator

Description:

Report of berry-lang/berry#300

Add a new method to copy a portion from a bytes() buffer to another bytes() object.

bytes().setbytes(offset_to:int, bytes_from:bytes [, offset_from:int, len_from:int]) -> nil

Copies by default the entire content of a buffer passed as argument starting at offset_to. The target buffer is not resized, so any buffer that does not fit is truncated.

You can optionally copy only a sub-section of the buffer, from offset_from and copy len_from bytes.

This will be useful for adressable leds / WS2812 animations.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit ee1ce20 into arendst:development Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant