-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for max485 #17247
Add support for max485 #17247
Conversation
Thx. The solution resembles the software serial This won't be merged as is. Considering the demand I will implement |
Add serial Modbus transmit enable GPIOs to all modbus energy drivers and modbus bridge (#17247)
@arendst this is not working for me and after reviewing the code I don't think it can work at all with hardware ports, since the transmit enable pin stays up just for the time you take to queue the bytes, the transmission then is async. |
Using latest Dev branches I can assure you it works as designed |
@arendst using ESP32 (m_hardserial = true), then m_tx_enable_pin stays high for about 250us, while the bits then take much longer to come out from the hardware serial port. |
SML implementation works because it correctly flush the fifo before disabling the TX EN pin. |
Ok so I just need to add the flush on esp32 hardware serial before disabling. |
Try latest dev and let me know if it fixes your issue. |
Works great. Thanks for doing it so fast! |
Description:
How to use it
Add the following lines to
user_config_override.h
:Wiring
Related issue (if applicable):
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass