Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition Wizard can be loaded dynamically #19980

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

s-hadinger
Copy link
Collaborator

Description:

A new button [Load Partition Wizard] allows to dynamically load from the Web the Partition Wizard without needing to download it first as a .tapp file.

image

When clicking on this button the first time, the partition_wizard.bec file is loaded into memory taking ~30KB of memory, and then acts like if the tapp file was present.

Code increase: 1300 bytes (whereas Partition Wizard is ~16KB)

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger
Copy link
Collaborator Author

s-hadinger commented Nov 11, 2023

Hmmm. If the partition wizard tapp file is already there, the button is displayed twice...

Edit: solved

@s-hadinger
Copy link
Collaborator Author

Let's try and get feedback

@s-hadinger s-hadinger merged commit de1b592 into arendst:development Nov 11, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant