Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid connection errors when switching to safeboot to upload OTA firmware #21428

Merged
merged 1 commit into from
May 17, 2024

Conversation

s-hadinger
Copy link
Collaborator

Description:

Fix occasional connection error when flashing ESP32 firmware via file upload.

Explanation: when uploading a new firmware with file upload, the first step is to restart Tasmota and switch to Safeboot partition. The browser polls the Tasmota device until it reboots and confirms that the safeboot is the active partition.

The partition switch is done by calling /u4?u4=fct&api=" which returns false if the partition is the normal one (and forces reboot) and true if it's the safeboot.

As soon as true is received, the browser send a POST request to upload the firmware. The problem is that sometimes the POST is sent too soon. I'm not sure why but the webserver initialization does not seem to be complete.

This patch adds a delay of 1 second between the confirmation of safeboot switch and sending the firmware.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 27c731c into arendst:development May 17, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant