Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S: multiple fixes #21511

Merged
merged 1 commit into from
May 28, 2024
Merged

I2S: multiple fixes #21511

merged 1 commit into from
May 28, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented May 27, 2024

Description:

  • better handle interruptions of operations, i.e. launching i2splay /file.mp3 while playing web radio
  • reducing noise before and after playing operations by adding an internal flush and preload method
  • more granular setting of volume (4 times the resolution) as my test with a PCM5102 via headphone was too rough with the old version
  • allow playing of mono MP3, which produced a ton of noise on the unused channel before in my tests, by modifying the framework
  • now correctly showing configured input and output on SOC's with 2 i2s channels
  • use correct output gain from settings file after boot
  • reject wrong sample rates for the MP3 encoder
  • a bit more logging as more issues are to be expected

Tested on a S3 dev board with a cheap PCM5102 and different connected microphones (PDM and INMP441), which interestingly absolutely needed the microphone input on the first channel (and the output on the second).
More research needed ...

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit a4dbc57 into arendst:development May 28, 2024
59 checks passed
@Staars Staars deleted the i2s branch July 11, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants