fix potential overflow on uptime 2nd try #21966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawa-lc4
pushed a commit
to hawa-lc4/Tasmota-dev
that referenced
this pull request
Sep 16, 2024
* fix potential overflow * fix potential overflow * fix overflow on millis() * fix overflow on millis() * Update xdrv_27_shutter.ino --------- Co-authored-by: Theo Arends <11044339+arendst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AFter 50 days the motorstoptime and the starttime do not show as expected because of an overflow of the millis() function. This causes an infinite loop() at the time you operate the shutter first time after the overflow of millis()
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass