Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HASPmota broken changed event #22194

Merged

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Sep 23, 2024

Description:

HASPmota fixes:

  • lv.EVENT_VALUE_CHANGED was wrongly mapped to lv.EVENT_DRAW_POST hence generating spam events
  • redesigned the event mapping for granular per class control
  • redesigned value reporting for lv.EVENT_VALUE_CHANGED event, to avoid the cost of raising exceptions
  • removed sending lv.EVENT_LONG_PRESSED_REPEAT (hold) message because it causes too much spam

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 17cc9e1 into arendst:development Sep 23, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant