Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error about lack of the explicit extensions #24

Closed
Andarist opened this issue May 7, 2023 · 1 comment
Closed

No error about lack of the explicit extensions #24

Andarist opened this issue May 7, 2023 · 1 comment

Comments

@Andarist
Copy link
Contributor

Andarist commented May 7, 2023

This reports that everything is alright:
https://arethetypeswrong.github.io/?p=ts-pattern%404.2.4-test.0

but in reality this version of this package isn't quite consumable from ESM:

node_modules/ts-pattern/dist/index.d.ts:1:26 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

1 import * as Pattern from './patterns';
                           ~~~~~~~~~~~~

node_modules/ts-pattern/dist/index.d.ts:2:23 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

2 export { match } from './match';
                        ~~~~~~~~~

node_modules/ts-pattern/dist/index.d.ts:3:28 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

3 export { isMatching } from './is-matching';
@andrewbranch
Copy link
Collaborator

Duplicate of #22

@andrewbranch andrewbranch marked this as a duplicate of #22 May 8, 2023
@andrewbranch andrewbranch closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants