Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed tests on Windows (10) #56

Closed
fredshone opened this issue Jun 25, 2024 · 0 comments · Fixed by #65
Closed

Failed tests on Windows (10) #56

fredshone opened this issue Jun 25, 2024 · 0 comments · Fixed by #65
Assignees
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:2-Backlog This issue has been claimed, but it's not being worked on right now, and it's not next to be tackled Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc.

Comments

@fredshone
Copy link
Contributor

Following "developer" installation I had failing tests due to missing solver:

git clone git@github.com:arfc/osier.git
cd osier
pip install .
pip install .[doc]
pip install pyomo==6.4.1
pytest

Results in (for example) pyomo.common.errors.ApplicationError: No executable found for solver 'cplex'.

Please move solver installation instructions from "Getting Started" to "Installation".

To allow a smoother onboarding for windows users I suggest adding installation instructions for glpk (eg conda install -c conda-forge glpk). I appreciate this might not be the best solver but it is more easilly accessible which is nice for casual users and will be easier for windows based CI.

@samgdotson samgdotson self-assigned this Jul 30, 2024
@samgdotson samgdotson added this to the JOSS publication -- Osier milestone Jul 30, 2024
@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:2-Backlog This issue has been claimed, but it's not being worked on right now, and it's not next to be tackled Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc. labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:2-Backlog This issue has been claimed, but it's not being worked on right now, and it's not next to be tackled Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants