-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MessagePackSerializer #370
Conversation
See #362 |
Thanks for the contribution! I won't have a laptop until the 9th. I'll check the builds and all that and then merge and do a new release :) |
@ahopkins the |
Got it. I'll add, and I also want to add use_list=False otherwise it cannot handle deaerializing dictionaries.
Adam Hopkins
…On Jan 15, 2018, 3:37 PM +0200, Manuel Miranda ***@***.***>, wrote:
@ahopkins the msgpack requirement is missing in setup.py :). Without it build can't pass
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 836 844 +8
Branches 88 89 +1
=====================================
+ Hits 836 844 +8
Continue to review full report at Codecov.
|
I've added some changes to finish this MR and pass the tests. I have removed the Once I have the next MR ready and MR will do a new release with all this. Thanks! |
Awesome! Much better idea.
…Sent from my iPhone
On Jan 16, 2018, at 5:30 PM, Manuel Miranda ***@***.***> wrote:
I've added some changes to finish this MR and pass the tests. I have removed the use_list option because instead of hardcoding it I want to allow the user to pass it in the constructor. Next MR will be about this :).
Once I have the next MR ready and MR will do a new release with all this.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Fixes #362