-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RankingQuestion
in the Python client
#3275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two minor comments
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3275 +/- ##
===========================================
- Coverage 90.91% 90.05% -0.86%
===========================================
Files 215 233 +18
Lines 11304 12410 +1106
===========================================
+ Hits 10277 11176 +899
- Misses 1027 1234 +207
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Failing tests are unrelated (as most of the times), I guess we could try to work on a PR to add HTTP retries, or split the integration tests from the unit tests to avoid the CI/CD runs from failing so much, WDYT @frascuchon @gabrielmbmb? |
Co-authored-by: Francisco Aranda <francis@argilla.io>
Co-authored-by: Gabriel Martin <gabriel@argilla.io>
Co-authored-by: Gabriel Martin <gabriel@argilla.io>
... labels={"cat-1": "Category 1" , "cat-2": "Category 2"}, | ||
... required=False, | ||
... visible_labels=4 | ||
... ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to add here a rg.RankingQuestion
? is the only one missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I think we should shorten the rest of them, as we have a lot of information that ends up being more than the actual code and it's hard to navigate through it, I think we can tackle the docstrings in the next release and use a clearer approach
Description
This PR includes the
RankingQuestion
, introduced in #3232, in the Python client, to allow users to create datasets withRankingQuestion
s and to submit responses for those too.Usage
Type of change
How Has This Been Tested
RankingQuestion
Checklist