Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update fields of RemoteFeedbackRecords #4329

Closed
plaguss opened this issue Nov 27, 2023 · 6 comments
Closed

[FEATURE] Update fields of RemoteFeedbackRecords #4329

plaguss opened this issue Nov 27, 2023 · 6 comments
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints area: python sdk Indicates that an issue or pull request is related to the Python SDK status: stale Indicates that there is no activity on an issue or pull request team: backend Indicates that the issue or pull request is owned by the backend team type: community request Indicates a feature requested by someone outside of the Argilla organization type: enhancement Indicates new feature requests

Comments

@plaguss
Copy link
Contributor

plaguss commented Nov 27, 2023

Is your feature request related to a problem? Please describe.
I would like to update the fields of RemoteFeedbackRecords.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Related to #4328

@dosubot dosubot bot added area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests labels Nov 27, 2023
Copy link

dosubot bot commented Nov 27, 2023

🤖

Hello @plaguss,

I'm Dosu, your friendly bot assistant for the Argilla repository! I'm here to help you navigate issues, answer questions, and help you contribute to our project. While we wait for a human maintainer to join us, feel free to ask me anything. I'm here to assist you.

Thank you for your feature request. Based on the information you've provided, it seems you want to update the fields of RemoteFeedbackRecords.

Currently, the update method in the RemoteFeedbackRecords class is used to update a list of RemoteFeedbackRecords in Argilla. The method accepts two arguments: records and show_progress. The records argument can be a single RemoteFeedbackRecord or a list of RemoteFeedbackRecord. The show_progress argument is a boolean that determines whether to show a progress bar while updating the records. Here is the source code for your reference.

As for the fields that can be updated, currently, the RemoteFeedbackRecord class in Argilla allows the suggestions field to be updated. This field can be updated using the update method. It accepts a single SuggestionSchema, a list of SuggestionSchema, a single dictionary, or a list of dictionaries. If a dictionary is provided, it will be converted to a SuggestionSchema internally. Here is the relevant source code.

Regarding your request's relation to issue #4328, without additional context or information about the issue, it's not possible to determine how this method or the proposed changes are related to it. Could you please provide more details about how you would like the fields of RemoteFeedbackRecords to be updated, any alternative solutions or features you've considered, and how this is related to issue #4328?

Also, there was a similar solved issue: allow for updating only certain fields of a record ID via rg.log projection, which was closed by a pull request: feat: Allow partial record update. This might provide some insights into your request.

Looking forward to your response.

Sources

@davidberenstein1957 davidberenstein1957 added this to the v1.21.0 milestone Nov 28, 2023
@nataliaElv
Copy link
Member

Hi @plaguss ! Is this issue related to a specific problem? What do you mean by updating fields?

@plaguss
Copy link
Contributor Author

plaguss commented Nov 28, 2023

Hi @nataliaElv! I think this really doesn't make sense, I saw we couldn't update this from the sdk (related to the #4328), but it doesn't make sense. I'll close this

@plaguss plaguss closed this as completed Nov 28, 2023
@davidberenstein1957 davidberenstein1957 added the area: python sdk Indicates that an issue or pull request is related to the Python SDK label Nov 28, 2023
@davidberenstein1957 davidberenstein1957 removed this from the v1.21.0 milestone Dec 12, 2023
@nataliaElv
Copy link
Member

This is definitely something that has come up in user interviews, but it has some implications in terms of dataset consistency. I'll add this to the triage so we can discuss internally.

@nataliaElv nataliaElv added the type: community request Indicates a feature requested by someone outside of the Argilla organization label Feb 22, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the status: stale Indicates that there is no activity on an issue or pull request label May 24, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints area: python sdk Indicates that an issue or pull request is related to the Python SDK status: stale Indicates that there is no activity on an issue or pull request team: backend Indicates that the issue or pull request is owned by the backend team type: community request Indicates a feature requested by someone outside of the Argilla organization type: enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

3 participants