resampleAudio implementation has bug when starttime and enttime is not nil

[Josscii]

should not comparing audioFile.framePosition with inputFrameCount , but something like this:

let endFrame = AVAudioFrameCount(audioFile.framePosition) + inputFrameCount

WhisperKit/Sources/WhisperKit/Core/AudioProcessor.swift

Lines 296 to 297 in c93d613

	while audioFile.framePosition < inputFrameCount {
	let remainingFrames = inputFrameCount - AVAudioFrameCount(audioFile.framePosition)

[ZachNagengast]

Thanks for the report, would you be able to post the specific exception? Or whatever test code you are using to reproduce the error?

[Josscii]

just the logic is wrong, when the audioFile is seeked to startTime, which changes its framePosition, and we should read from the frameposition until it reaches the framePosition + frameCount.

[ZachNagengast]

I think I see what you mean, so we need to calculate the ending framePosition for cases where the starting framePosition is not 0, does that sound right?

[Josscii]

yes, I'm using the loadAudio function to load audio buffer from time1 to time2, and found that the resampleAudio is not entering the while loop.

[ZachNagengast]

@Josscii I've fixed some of the logic in #195, please try it out and see if it works for your use case.

[Josscii]

Thanks for your work, I checked the code, and I think it fixed the bug.