Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp Rules Logits Filter #24

Closed
ZachNagengast opened this issue Feb 16, 2024 · 1 comment · Fixed by #45
Closed

Timestamp Rules Logits Filter #24

ZachNagengast opened this issue Feb 16, 2024 · 1 comment · Fixed by #45
Assignees
Labels
feature New feature or request triaged This issue has been looked at and prioritized by a maintainer

Comments

@ZachNagengast
Copy link
Contributor

Timestamp rules are helpful to more consistently find reliable timestamps during decoding.

Important note: We have already brought over some of this logic into the SegmentSeeker which runs at the end of a full decode loop to generate the segments. This feature will need to detangle any repeated logic between them.

References:

Openai implementation: https://github.com/openai/whisper/blob/ba3f3cd54b0e5b8ce1ab3de13e32122d0d5f98ab/whisper/decoding.py#L441-L505

@ZachNagengast ZachNagengast converted this from a draft issue Feb 16, 2024
@ZachNagengast ZachNagengast added triaged This issue has been looked at and prioritized by a maintainer feature New feature or request labels Feb 16, 2024
@jkrukowski
Copy link
Contributor

I can take it

@ZachNagengast ZachNagengast moved this from TODO: Features to In Progress in WhisperKit Mar 8, 2024
@ZachNagengast ZachNagengast linked a pull request Mar 8, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in WhisperKit Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request triaged This issue has been looked at and prioritized by a maintainer
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants