-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementation for SuppressTokensFilter #14
Conversation
Awesome contribution! Reviewing this shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @jkrukowski just a couple small notes, will run through the full tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good, everything is passing, well done!
Would love to see your take on the other filters if you're up for it! I'm going to be looking at word-level timestamps next on my side FYI, so we'll definitely need timestamp filtering i.e. |
sure, happy to do it. Will try to find some time this or next week |
hi @ZachNagengast, not sure if it's a good place to ask but you mentioned that some of this logic was pulled into |
If this PR looks good, I can try to implement other filters 🫡