Fix start time logic for file loading #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191
Issue occurs when an audio file requires resampling and startTime is not 0. Previously, the resample function calculated the total frame count and reading up to that number as the frame position (which would imply that the start time was always 0 in the resample function). The solution involves calculating the start and end frame positions by incorporating the starting frame position as an offset and reading up to the end position correctly rather than just the total frame count.
startTime
is not 0maxReadFrameSize
for easier memory management with large files