You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because ArgoCD applications are actually CRDs within the cluster where a team's ArgoCD instance was installed — all applications need have to be globally unique names. This is related to an ArgoCD issue requesting that ArgoCD applications be somehow project scoped, however the AppSource controller workflow should not wait for ArgoCD as a whole to be changed. Instead, the name of the ArgoCD Application will be <cluster>.<namespace>.<appsource.name>
Motivation
The appsource controller promotes its utility across multiple clusters, not just the one where the ArgoCD instance may be installed. With this updated syncPolicy we can ensure that applications are being made within their own namespaces, no matter what cluster they're being requested from.
Proposal
Create ArgoCD Applications with the name format <cluster>.<namespace>.<appsource.name>
The text was updated successfully, but these errors were encountered:
I've add comments under the open PR for this issue #41, if anyone would like to pick this up all that we need to figure out is how to get the cluster name through the kubernetes/client-go API and add it to the Sprintf command added in the lastest commit.
Summary
Thank you to @keithchong for inspiring this fix.
Because ArgoCD applications are actually CRDs within the cluster where a team's ArgoCD instance was installed — all applications need have to be globally unique names. This is related to an ArgoCD issue requesting that ArgoCD applications be somehow project scoped, however the AppSource controller workflow should not wait for ArgoCD as a whole to be changed. Instead, the name of the ArgoCD Application will be <cluster>.<namespace>.<appsource.name>
Motivation
The appsource controller promotes its utility across multiple clusters, not just the one where the ArgoCD instance may be installed. With this updated syncPolicy we can ensure that applications are being made within their own namespaces, no matter what cluster they're being requested from.
Proposal
Create ArgoCD Applications with the name format <cluster>.<namespace>.<appsource.name>
The text was updated successfully, but these errors were encountered: