Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making AppSource created ArgoCD Applications Project Scoped #38

Open
aceamarco opened this issue Aug 6, 2021 · 1 comment · May be fixed by #41
Open

Making AppSource created ArgoCD Applications Project Scoped #38

aceamarco opened this issue Aug 6, 2021 · 1 comment · May be fixed by #41
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aceamarco
Copy link
Collaborator

aceamarco commented Aug 6, 2021

Summary

Thank you to @keithchong for inspiring this fix.

Because ArgoCD applications are actually CRDs within the cluster where a team's ArgoCD instance was installed — all applications need have to be globally unique names. This is related to an ArgoCD issue requesting that ArgoCD applications be somehow project scoped, however the AppSource controller workflow should not wait for ArgoCD as a whole to be changed. Instead, the name of the ArgoCD Application will be <cluster>.<namespace>.<appsource.name>

Motivation

The appsource controller promotes its utility across multiple clusters, not just the one where the ArgoCD instance may be installed. With this updated syncPolicy we can ensure that applications are being made within their own namespaces, no matter what cluster they're being requested from.

Proposal

Create ArgoCD Applications with the name format <cluster>.<namespace>.<appsource.name>

@aceamarco aceamarco added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2021
@aceamarco aceamarco self-assigned this Aug 6, 2021
@aceamarco
Copy link
Collaborator Author

I've add comments under the open PR for this issue #41, if anyone would like to pick this up all that we need to figure out is how to get the cluster name through the kubernetes/client-go API and add it to the Sprintf command added in the lastest commit.

@aceamarco aceamarco removed their assignment Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant