Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test is broken with cappa dependency #907

Closed
2 of 6 tasks
paravatha opened this issue Dec 23, 2023 · 1 comment
Closed
2 of 6 tasks

make test is broken with cappa dependency #907

paravatha opened this issue Dec 23, 2023 · 1 comment

Comments

@paravatha
Copy link
Contributor

Pre-bug-report checklist

1. This bug can be reproduced using pure Argo YAML

If yes, it is more likely to be an Argo bug unrelated to Hera. Please double check before submitting an issue to Hera.

2. This bug occurs in Hera when...

  • exporting to YAML
  • submitting to Argo
  • running on Argo with the Hera runner
  • other:

Bug report

Describe the bug
make lint testand make test are throwing this error

I tried with python 3..8 and python 3.11, same issue occurs for both python versions

Error log if applicable:

397 files left unchanged
src/hera/_cli/base.py:7: error: Cannot find implementation or library stub for module named "cappa"  [import]
src/hera/__main__.py:15: error: Cannot find implementation or library stub for module named "cappa"  [import]
src/hera/__main__.py:15: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 2 errors in 2 files (checked 113 source files)
make: *** [lint] Error 1

Environment

  • Python Version: 3.11 and 3.8

Additional context
Add any other context about the problem here.

@elliotgunton
Copy link
Collaborator

Hey @paravatha - could you rerun make install? I think you just need to refresh your python environment! This was fixed in #905 here. Closing as fixed (reopen if a new environment doesn't help!) - I couldn't reproduce in a fresh environment:

$ make install
Creating virtualenv hera-ZUOVT4Nk-py3.10 in /home/codespace/.cache/pypoetry/virtualenvs
...

Installing the current project: hera (0.0.0-dev)
$ make lint
396 files left unchanged
Success: no issues found in 113 source files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants